Ggtcf

I am doing a program that involve creating an account, I need to create so that it will scan specific data to carry out an assigned command. is the getter and setter function suitable for it?

public class Account {

 //data
 private int userId;
 private String password;
 private char type;

 public Account(int userId, String password, char type) 
 this.userId = userId;
 this.password = password;
 this.type = type;
 

 public int getUserId() 
 return userId;
 

 public void setUserId(int userId) 
 this.userId = userId;
 

 public String getPassword() 
 return password;
 

 public void setPassword(String password) 
 this.password = password;
 

 public char getType() 
 return type;
 

 public void setType(char type) 
 this.type = type;
 


 //methods
 public boolean verifyLogin(int usrid , String pass)
 
 if((usrid == userId) & (pass == password))
 return true;
 
 else
 return false;
 

Your getters and setters look fine for accessing the data of this class.

Something you need to be very careful with is how you check if the password is correct.

In your implementation you use pass == password for comparing two strings. This is NOT correct and you should rather use pass.equals(password).

It looks fine, but you need to rethink if Setters for some values are necessary. In example it is not very common use case that UserID will change somehow. If you want to keep it persistant, setter is not necessary. Set it once in constructor.

Additionally you can take a look on the Lombok Project and @Getter & @Setter annotation. It will minimalize your code to 3 lines.