Ggtcf

Inherited a website that has a calculator form running that broke when host updated server to PHP7.2 from 5.6. Looking at error logs the issue seems to be with passing the $data to the function correctly.

The error that I am getting is

PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function CalculateTitleFee()

It says that it is getting 1 argument but expecting 2. In my browser I can see the 500 error on the URL that clearly shows 2 values for data.

My initial guess is either that the GET isn't working correctly, or that it isn't building the data into an array correctly.

Here is the PHP in question.

It all starts with:

$action = $_GET['action'];

$json_data = array();
$json_data['error_code'] = '0';

// Determine the action that the javascript is attempting to perform
switch ($action) 
 case "display_main_menu":
 case "back":
 $json_data['html'] = display_main_menu();
 break;
 case "display_purchase_example":
 $json_data['html'] = display_purchase_example();
 break;
 case "display_refinance_example":
 $json_data['html'] = display_refinance_example();
 break;
 case "calculate": 
 $post_data = $_GET['data'];

 $json_data['calc_data'] = calculate($post_data);
 break;


echo json_encode($json_data);

The form is then sending:

urltophp.php?action=calculate&data%5B%5D=80000&data%5B%5D=90000

Here is the calculate function:

function calculate($data) 

 $calc_data = array();
 $title_premium = CalculateTitleFee(floatval($data[1])) + CalculateLoanPolicy(floatval($data[0]));
 $title_premium_refi = CalculateTitleFeeRefi(floatval($data[0]));

That function has a lot going on that I didn't copy, but the error is happening CalculateTitleFee() function. Hoping to resolve that and everything else works correctly.

===== UPDATE =====

Here is the CalculateTitleFee function.

function CalculateTitleFee ($purchase_price, $loan_amount)
 $title_premium0 = 0;

 if ($purchase_price <= "100000") 
 $title_premium0 = ((ceil((($purchase_price-30000)*0.00375)+180)-(ceil((($purchase_price-30000)*0.00325)+150)))+100);
 
 else if ($purchase_price <= "200000") 
 $title_premium0 = ((ceil((($purchase_price-100000)*0.00275)+442.5)-(ceil((($purchase_price-100000)*0.00225)+377.5)))+100);
 
 else if ($purchase_price <= "300000") 
 $title_premium0 = ((ceil((($purchase_price-200000)*0.002)+717.5)-(ceil((($purchase_price-200000)*0.00175)+602.5)))+100);
 
 else if ($purchase_price <= "10000000") 
 $title_premium0 = ((ceil((($purchase_price-200000)*0.002)+717.5)-(ceil((($purchase_price-200000)*0.00175)+602.5)))+100);
 

 return $title_premium0;

 

This is not because of $_GET. This was always a problem, but only started throwing an exception when you updated to PHP 7. Too few arguments used to cause a warning, as of PHP 7.1 it causes an error.

In your calculate() function, you are calling CalculateTitleFee with only one argument.

CalculateTitleFee(floatval($data[1]))

CalculateTitleFee() does take a second argument, but it is never used in the function. It should be safe to remove that parameter from the function definition.